Fixed HTTPSTAT_SAVE_BODY not working with HTTPSTAT_METRICS_ONLY #49
Conversation
…AT_SAVE_RESPONSE and HTTPSTAT_METRICS_ONLY interactions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Miracle05, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a bug where the option to save the HTTP response was not respected when the tool was run in 'metrics only' mode. The core change ensures that temporary files containing the response body and headers are only removed if the user explicitly opts not to save them, even when only metrics are being displayed. Additionally, the relevant environment variable and internal parameters have been renamed for better semantic clarity.
Highlights
- Bug Fix: Corrected an issue where the
HTTPSTAT_SAVE_BODY(nowHTTPSTAT_SAVE_RESPONSE) environment variable was ignored whenHTTPSTAT_METRICS_ONLYwas active. Previously, temporary response files were always deleted, even if the user intended to save them. The fix ensures these files are retained whensave_responseis enabled. - Refactoring/Renaming: Renamed the
HTTPSTAT_SAVE_BODYenvironment variable and its corresponding internal variables/parameters toHTTPSTAT_SAVE_RESPONSE. This change improves clarity and accuracy, as the variable controls saving the entire response (including headers), not just the body.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request fixes an issue where temporary files were not properly cleaned up when HTTPSTAT_METRICS_ONLY was enabled. The environment variable HTTPSTAT_SAVE_BODY was renamed to HTTPSTAT_SAVE_RESPONSE for better clarity. Ensure that the help text, README, and test script are updated to reflect these changes.
| if not save_response: | ||
| lg.debug('rm header file %s', headerf.name) | ||
| os.remove(headerf.name) | ||
| lg.debug('rm body file %s', bodyf.name) | ||
| os.remove(bodyf.name) |
There was a problem hiding this comment.
This block removes both header and body files when metrics_only is enabled and save_response is false, which fixes the original issue. Good job!
| if not save_response: | ||
| lg.debug('rm body file %s', bodyf.name) | ||
| os.remove(bodyf.name) |
There was a problem hiding this comment.
This block removes the body file when save_response is false. This ensures that temporary files are cleaned up when they are no longer needed, preventing potential disk space issues.
| ENV_SHOW_IP = Env('{prefix}_SHOW_IP') | ||
| ENV_SHOW_SPEED = Env('{prefix}_SHOW_SPEED') | ||
| ENV_SAVE_BODY = Env('{prefix}_SAVE_BODY') | ||
| ENV_SAVE_RESPONSE = Env('{prefix}_SAVE_RESPONSE') |
There was a problem hiding this comment.
Renaming ENV_SAVE_BODY to ENV_SAVE_RESPONSE improves clarity. Ensure corresponding updates are made in the help text (lines 143-144) and README.md to reflect this change.
| show_ip = 'true' in ENV_SHOW_IP.get('true').lower() | ||
| show_speed = 'true'in ENV_SHOW_SPEED.get('false').lower() | ||
| save_body = 'true' in ENV_SAVE_BODY.get('true').lower() | ||
| save_response = 'true' in ENV_SAVE_RESPONSE.get('true').lower() |
There was a problem hiding this comment.
Renaming save_body to save_response improves clarity. Ensure corresponding updates are made in the test script httpstat_test.sh (lines 85-109).
| show_ip=show_ip, | ||
| show_speed=show_speed, | ||
| save_body=save_body, | ||
| save_response=save_response, |
There was a problem hiding this comment.
Renaming save_body to save_response improves clarity. Ensure corresponding updates are made in the test script httpstat_test.sh (lines 85-109).
1 participant
HTTPSTAT_SAVE_BODY not working with HTTPSTAT_METRICS_ONLY, fixed this behaviour